Skip to content

Commit 2b72a45

Browse files
Trottdanielleadams
authored andcommittedApr 5, 2023
build: add GitHub Action for coverage with --without-intl
There are parts of the code base that require a build without intl to be covered. So add a coverage job to build --without-intl. PR-URL: #37954 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent ff07aa7 commit 2b72a45

File tree

1 file changed

+69
-0
lines changed

1 file changed

+69
-0
lines changed
 
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,69 @@
1+
name: Coverage Linux (without intl)
2+
3+
on:
4+
pull_request:
5+
types: [opened, synchronize, reopened, ready_for_review]
6+
paths-ignore:
7+
- '**.md'
8+
- benchmark/**
9+
- deps/**
10+
- doc/**
11+
- .github/**
12+
- '!.github/workflows/coverage-linux-without-intl.yml'
13+
push:
14+
branches:
15+
- main
16+
paths-ignore:
17+
- '**.md'
18+
- benchmark/**
19+
- deps/**
20+
- doc/**
21+
- .github/**
22+
- '!.github/workflows/coverage-linux-without-intl.yml'
23+
24+
concurrency:
25+
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
26+
cancel-in-progress: true
27+
28+
env:
29+
PYTHON_VERSION: '3.11'
30+
FLAKY_TESTS: keep_retrying
31+
32+
permissions:
33+
contents: read
34+
35+
jobs:
36+
coverage-linux-without-intl:
37+
if: github.event.pull_request.draft == false
38+
runs-on: ubuntu-latest
39+
steps:
40+
- uses: actions/checkout@v3
41+
with:
42+
persist-credentials: false
43+
- name: Set up Python ${{ env.PYTHON_VERSION }}
44+
uses: actions/setup-python@v4
45+
with:
46+
python-version: ${{ env.PYTHON_VERSION }}
47+
- name: Environment Information
48+
run: npx envinfo
49+
- name: Install gcovr
50+
run: pip install gcovr==4.2
51+
- name: Build
52+
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn --coverage --without-intl"
53+
# TODO(bcoe): fix the couple tests that fail with the inspector enabled.
54+
# The cause is most likely coverage's use of the inspector.
55+
- name: Test
56+
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j2 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9" || exit 0
57+
- name: Report JS
58+
run: npx c8 report --check-coverage
59+
env:
60+
NODE_OPTIONS: --max-old-space-size=8192
61+
- name: Report C++
62+
run: cd out && gcovr --gcov-exclude='.*\b(deps|usr|out|obj|cctest|embedding)\b' -v -r Release/obj.target --xml -o ../coverage/coverage-cxx.xml --root=$(cd ../ && pwd)
63+
# Clean temporary output from gcov and c8, so that it's not uploaded:
64+
- name: Clean tmp
65+
run: rm -rf coverage/tmp && rm -rf out
66+
- name: Upload
67+
uses: codecov/codecov-action@v3
68+
with:
69+
directory: ./coverage

0 commit comments

Comments
 (0)
Please sign in to comment.