From 30264490093db835eebf05415d30eed8eb20e93c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tobias=20Nie=C3=9Fen?= Date: Tue, 1 Mar 2022 17:21:18 +0100 Subject: [PATCH] src: remove dead code in AddFingerprintDigest This function is never called with md_size == 0, and it would make no sense to do so in the future either. PR-URL: https://github.com/nodejs/node/pull/42145 Reviewed-By: Colin Ihrig Reviewed-By: Darshan Sen --- src/crypto/crypto_common.cc | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/crypto/crypto_common.cc b/src/crypto/crypto_common.cc index 468a0892132b14..372a3f147b0795 100644 --- a/src/crypto/crypto_common.cc +++ b/src/crypto/crypto_common.cc @@ -427,11 +427,8 @@ void AddFingerprintDigest( fingerprint[(3*i)+2] = ':'; } - if (md_size > 0) { - fingerprint[(3*(md_size-1))+2] = '\0'; - } else { - fingerprint[0] = '\0'; - } + DCHECK_GT(md_size, 0); + fingerprint[(3 * (md_size - 1)) + 2] = '\0'; } template