From 317a1d7a0d8078a32d641f119b351080c938c6b8 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 21 Dec 2020 06:10:12 -0800 Subject: [PATCH] doc: remove replication of GitHub template MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The pull-request template was replicated in the pull-requests.md which is a maintenance annoyance when changing the template. Replace the replication with a link to the raw template. PR-URL: https://github.com/nodejs/node/pull/36590 Reviewed-By: Richard Lau Reviewed-By: Michaƫl Zasso Reviewed-By: Antoine du Hamel Reviewed-By: Anna Henningsen Reviewed-By: Daijiro Wachi --- doc/guides/contributing/pull-requests.md | 32 +++--------------------- 1 file changed, 4 insertions(+), 28 deletions(-) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 627ae2218a7b6d..4ca1df219bb941 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -268,34 +268,9 @@ $ git push origin my-branch ### Step 8: Opening the Pull Request -From within GitHub, opening a new Pull Request will present you with a template -that should be filled out: - -```markdown - - -#### Related Issues - -Fixes: https://github.com/nodejs/node/issues/ - -#### Checklist - - -- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes -- [ ] tests and/or benchmarks are included -- [ ] documentation is changed or added -- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines) -``` - -Please try to do your best at filling out the details, but feel free to skip -parts if you're not sure what to put. +From within GitHub, opening a new Pull Request will present you with a +[pull request template][]. Please try to do your best at filling out the +details, but feel free to skip parts if you're not sure what to put. Once opened, Pull Requests are usually reviewed within a few days. @@ -630,4 +605,5 @@ More than one subsystem may be valid for any particular issue or pull request. [guide for writing tests in Node.js]: ../writing-tests.md [hiding-a-comment]: https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment [https://ci.nodejs.org/]: https://ci.nodejs.org/ +[pull request template]: https://raw.githubusercontent.com/nodejs/node/master/.github/PULL_REQUEST_TEMPLATE.md [running tests]: ../../../BUILDING.md#running-tests