From 31994fbf8e9e7c6f59a78c14d687e82c877ba660 Mon Sep 17 00:00:00 2001
From: Joyee Cheung <joyeec9h3@gmail.com>
Date: Tue, 7 Sep 2021 02:44:14 +0800
Subject: [PATCH] src: register zlib external references for snapshot
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PR-URL: https://github.com/nodejs/node/pull/40050
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
---
 src/node_external_reference.h |  1 +
 src/node_zlib.cc              | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)

diff --git a/src/node_external_reference.h b/src/node_external_reference.h
index 4ebaa8d27feae8..f51999e996fd06 100644
--- a/src/node_external_reference.h
+++ b/src/node_external_reference.h
@@ -81,6 +81,7 @@ class ExternalReferenceRegistry {
   V(types)                                                                     \
   V(uv)                                                                        \
   V(v8)                                                                        \
+  V(zlib)                                                                      \
   V(worker)
 
 #if NODE_HAVE_I18N_SUPPORT
diff --git a/src/node_zlib.cc b/src/node_zlib.cc
index b8733229b0b06b..ec0a8e90f1cbcf 100644
--- a/src/node_zlib.cc
+++ b/src/node_zlib.cc
@@ -25,6 +25,7 @@
 
 #include "async_wrap-inl.h"
 #include "env-inl.h"
+#include "node_external_reference.h"
 #include "threadpoolwork-inl.h"
 #include "util-inl.h"
 
@@ -1266,6 +1267,16 @@ struct MakeClass {
 
     env->SetConstructorFunction(target, name, z);
   }
+
+  static void Make(ExternalReferenceRegistry* registry) {
+    registry->Register(Stream::New);
+    registry->Register(Stream::template Write<true>);
+    registry->Register(Stream::template Write<false>);
+    registry->Register(Stream::Close);
+    registry->Register(Stream::Init);
+    registry->Register(Stream::Params);
+    registry->Register(Stream::Reset);
+  }
 };
 
 void Initialize(Local<Object> target,
@@ -1283,6 +1294,12 @@ void Initialize(Local<Object> target,
               FIXED_ONE_BYTE_STRING(env->isolate(), ZLIB_VERSION)).Check();
 }
 
+void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
+  MakeClass<ZlibStream>::Make(registry);
+  MakeClass<BrotliEncoderStream>::Make(registry);
+  MakeClass<BrotliDecoderStream>::Make(registry);
+}
+
 }  // anonymous namespace
 
 void DefineZlibConstants(Local<Object> target) {
@@ -1408,3 +1425,4 @@ void DefineZlibConstants(Local<Object> target) {
 }  // namespace node
 
 NODE_MODULE_CONTEXT_AWARE_INTERNAL(zlib, node::Initialize)
+NODE_MODULE_EXTERNAL_REFERENCE(zlib, node::RegisterExternalReferences)