From 325254cc2cf0061dcf0f43092ec7c4632f1ca5de Mon Sep 17 00:00:00 2001 From: Obiwac Date: Wed, 26 Oct 2022 18:31:26 +0200 Subject: [PATCH] src: remap invalid file descriptors using `dup2` When checking for the validity of the stdio file descriptors (nodejs#875), ones which don't exist are intended to be remapped to /dev/null (and, if that doesn't work, we abort). This however doesn't work on all platforms and in all cases, and is not anymore required by POSIX; instead, use the `dup2` syscall as a more robust solution (conforms to POSIX.1). Fixes: https://github.com/nodejs/help/issues/2411 Refs: https://github.com/nodejs/node/pull/875 PR-URL: https://github.com/nodejs/node/pull/44461 Reviewed-By: Anna Henningsen Reviewed-By: Joyee Cheung Reviewed-By: Ben Noordhuis --- src/node.cc | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/src/node.cc b/src/node.cc index 9906a917d2ea9a..2057d4388acbff 100644 --- a/src/node.cc +++ b/src/node.cc @@ -469,11 +469,32 @@ static void PlatformInit(ProcessInitializationFlags::Flags flags) { for (auto& s : stdio) { const int fd = &s - stdio; if (fstat(fd, &s.stat) == 0) continue; + // Anything but EBADF means something is seriously wrong. We don't // have to special-case EINTR, fstat() is not interruptible. if (errno != EBADF) ABORT(); - if (fd != open("/dev/null", O_RDWR)) ABORT(); - if (fstat(fd, &s.stat) != 0) ABORT(); + + // If EBADF (file descriptor doesn't exist), open /dev/null and duplicate + // its file descriptor to the invalid file descriptor. Make sure *that* + // file descriptor is valid. POSIX doesn't guarantee the next file + // descriptor open(2) gives us is the lowest available number anymore in + // POSIX.1-2017, which is why dup2(2) is needed. + int null_fd; + + do { + null_fd = open("/dev/null", O_RDWR); + } while (null_fd < 0 && errno == EINTR); + + if (null_fd != fd) { + int err; + + do { + err = dup2(null_fd, fd); + } while (err < 0 && errno == EINTR); + CHECK_EQ(err, 0); + } + + if (fstat(fd, &s.stat) < 0) ABORT(); } }