Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
quic: resolve some minor TODOs
PR-URL: #34655
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
jasnell committed Aug 17, 2020
1 parent 1e6e5c3 commit 34165f0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
2 changes: 0 additions & 2 deletions lib/internal/quic/core.js
Expand Up @@ -517,7 +517,6 @@ function createSecureContext(options, init_cb) {
const sc_options = validateCreateSecureContextOptions(options);
const { groups, earlyData } = sc_options;
const sc = _createSecureContext(sc_options);
// TODO(@jasnell): Determine if it's really necessary to pass in groups here.
init_cb(sc.context, groups, earlyData);
return sc;
}
Expand Down Expand Up @@ -2702,7 +2701,6 @@ class QuicStream extends Duplex {
}

[kInspect](depth, options) {
// TODO(@jasnell): Proper custom inspect implementation
const direction = this.bidirectional ? 'bidirectional' : 'unidirectional';
const initiated = this.serverInitiated ? 'server' : 'client';
return customInspect(this, {
Expand Down
9 changes: 5 additions & 4 deletions src/quic/node_quic_session.cc
Expand Up @@ -3378,8 +3378,10 @@ int QuicSession::OnStreamReset(
// sensitivity of PATH_CHALLENGE operations (an attacker
// could use a compromised PATH_CHALLENGE to trick an endpoint
// into redirecting traffic).
// TODO(@jasnell): In the future, we'll want to explore whether
// we want to handle the different cases of ngtcp2_rand_ctx
//
// The ngtcp2_rand_ctx tells us what the random data is used for.
// Currently, there is only one use. In the future, we'll want to
// explore whether we want to handle the different cases uses.
int QuicSession::OnRand(
ngtcp2_conn* conn,
uint8_t* dest,
Expand Down Expand Up @@ -3744,8 +3746,7 @@ void QuicSessionSilentClose(const FunctionCallbackInfo<Value>& args) {
session->Close(QuicSessionListener::SESSION_CLOSE_FLAG_SILENT);
}

// TODO(addaleax): This is a temporary solution for testing and should be
// removed later.
// This is used purely for testing.
void QuicSessionRemoveFromSocket(const FunctionCallbackInfo<Value>& args) {
QuicSession* session;
ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder());
Expand Down

0 comments on commit 34165f0

Please sign in to comment.