From 35f45ba47b6fe9474a285483044ec27bd0a22896 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 22 Jan 2019 14:17:22 -0800 Subject: [PATCH] test: remove known_issues/test-cluster-bind-privileged-port The test was added to check for a bug in macOS Mojave, but it turns out the issue is a macOS feature, not a bug. Refs: https://github.com/nodejs/node/issues/21679#issuecomment-456589386 Fixes: https://github.com/nodejs/node/issues/21679 PR-URL: https://github.com/nodejs/node/pull/25649 Reviewed-By: Colin Ihrig Reviewed-By: Gus Caplan --- .../test-cluster-bind-privileged-port.js | 25 ------------------- 1 file changed, 25 deletions(-) delete mode 100644 test/known_issues/test-cluster-bind-privileged-port.js diff --git a/test/known_issues/test-cluster-bind-privileged-port.js b/test/known_issues/test-cluster-bind-privileged-port.js deleted file mode 100644 index 6ada04aa030b31..00000000000000 --- a/test/known_issues/test-cluster-bind-privileged-port.js +++ /dev/null @@ -1,25 +0,0 @@ -'use strict'; -const common = require('../common'); - -// This test should fail on macOS (10.14) due to an issue with privileged ports. - -const assert = require('assert'); -const cluster = require('cluster'); -const net = require('net'); - -if (!common.isOSXMojave) - assert.fail('Code should fail only on macOS Mojave.'); - - -if (cluster.isMaster) { - cluster.fork().on('exit', common.mustCall((exitCode) => { - assert.strictEqual(exitCode, 0); - })); -} else { - const s = net.createServer(common.mustNotCall()); - s.listen(42, common.mustNotCall('listen should have failed')); - s.on('error', common.mustCall((err) => { - assert.strictEqual(err.code, 'EACCES'); - process.disconnect(); - })); -}