Skip to content

Commit 380600d

Browse files
mmarchiniaddaleax
authored andcommittedSep 22, 2020
build: set --v8-enable-object-print by default
The flag improves the experience of debugging V8 with native debuggers. It doens't incur performance penality, the only downside is an increase in binary size by approximately 248 Kb. Ref: #32834 PR-URL: #34705 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
1 parent 45d712c commit 380600d

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed
 

‎common.gypi

+3
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@
5555
# Enable disassembler for `--print-code` v8 options
5656
'v8_enable_disassembler': 1,
5757

58+
# Sets -dOBJECT_PRINT.
59+
'v8_enable_object_print%': 1,
60+
5861
# https://github.com/nodejs/node/pull/22920/files#r222779926
5962
'v8_enable_handle_zapping': 0,
6063

‎configure.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -651,7 +651,7 @@
651651
parser.add_option('--v8-enable-object-print',
652652
action='store_true',
653653
dest='v8_enable_object_print',
654-
default=False,
654+
default=True,
655655
help='compile V8 with auxiliar functions for native debuggers')
656656

657657
parser.add_option('--node-builtin-modules-path',

0 commit comments

Comments
 (0)
Please sign in to comment.