Skip to content

Commit 3a864d7

Browse files
Nolan Rigorvagg
Nolan Rigo
authored andcommittedNov 28, 2018
test: fix strictEqual() arguments order
PR-URL: #23800 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
1 parent 3f2a016 commit 3a864d7

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed
 

‎test/parallel/test-http-upgrade-server.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -98,20 +98,20 @@ function test_upgrade_with_listener() {
9898
conn.on('data', function(data) {
9999
state++;
100100

101-
assert.strictEqual('string', typeof data);
101+
assert.strictEqual(typeof data, 'string');
102102

103103
if (state === 1) {
104-
assert.strictEqual('HTTP/1.1 101', data.substr(0, 12));
105-
assert.strictEqual('WjN}|M(6', request_upgradeHead.toString('utf8'));
104+
assert.strictEqual(data.substr(0, 12), 'HTTP/1.1 101');
105+
assert.strictEqual(request_upgradeHead.toString('utf8'), 'WjN}|M(6');
106106
conn.write('test', 'utf8');
107107
} else if (state === 2) {
108-
assert.strictEqual('test', data);
108+
assert.strictEqual(data, 'test');
109109
conn.write('kill', 'utf8');
110110
}
111111
});
112112

113113
conn.on('end', function() {
114-
assert.strictEqual(2, state);
114+
assert.strictEqual(state, 2);
115115
conn.end();
116116
server.removeAllListeners('upgrade');
117117
test_upgrade_no_listener();
@@ -157,8 +157,8 @@ function test_standard_http() {
157157
});
158158

159159
conn.once('data', function(data) {
160-
assert.strictEqual('string', typeof data);
161-
assert.strictEqual('HTTP/1.1 200', data.substr(0, 12));
160+
assert.strictEqual(typeof data, 'string');
161+
assert.strictEqual(data.substr(0, 12), 'HTTP/1.1 200');
162162
conn.end();
163163
});
164164

@@ -180,7 +180,7 @@ server.listen(0, function() {
180180
Fin.
181181
-----------------------------------------------*/
182182
process.on('exit', function() {
183-
assert.strictEqual(3, requests_recv);
184-
assert.strictEqual(3, requests_sent);
183+
assert.strictEqual(requests_recv, 3);
184+
assert.strictEqual(requests_sent, 3);
185185
assert.ok(test_upgrade_no_listener_ended);
186186
});

0 commit comments

Comments
 (0)
Please sign in to comment.