Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
test: add semicolon after chunk size
The ABNF for chunk extensions as per RFC 7230 is

    chunk-ext      = *( ";" chunk-ext-name [ "=" chunk-ext-val ] )

    chunk-ext-name = token
    chunk-ext-val  = token / quoted-string

Add a semicolon after the chunk size for clarity.

This does not invalidate the test as it verifies that the HTTP parser
does not ignore chunk extensions.

PR-URL: #40487
Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
lpinca authored and BethGriggs committed Nov 25, 2021
1 parent f114e35 commit 3d50997
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/parallel/test-http-chunked-smuggling.js
Expand Up @@ -23,7 +23,7 @@ function start() {
'Host: localhost:8080\r\n' +
'Transfer-Encoding: chunked\r\n' +
'\r\n' +
'2 \n' +
'2;\n' +
'xx\r\n' +
'4c\r\n' +
'0\r\n' +
Expand Down

0 comments on commit 3d50997

Please sign in to comment.