From 3d50997ccb1720233f1bec4cd4caf938ec2c0351 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Sun, 17 Oct 2021 10:35:10 +0200 Subject: [PATCH] test: add semicolon after chunk size The ABNF for chunk extensions as per RFC 7230 is chunk-ext = *( ";" chunk-ext-name [ "=" chunk-ext-val ] ) chunk-ext-name = token chunk-ext-val = token / quoted-string Add a semicolon after the chunk size for clarity. This does not invalidate the test as it verifies that the HTTP parser does not ignore chunk extensions. PR-URL: https://github.com/nodejs/node/pull/40487 Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling Reviewed-By: James M Snell --- test/parallel/test-http-chunked-smuggling.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-http-chunked-smuggling.js b/test/parallel/test-http-chunked-smuggling.js index 112772ee12e913..dbad45e1be319f 100644 --- a/test/parallel/test-http-chunked-smuggling.js +++ b/test/parallel/test-http-chunked-smuggling.js @@ -23,7 +23,7 @@ function start() { 'Host: localhost:8080\r\n' + 'Transfer-Encoding: chunked\r\n' + '\r\n' + - '2 \n' + + '2;\n' + 'xx\r\n' + '4c\r\n' + '0\r\n' +