From 415571287e9ac7659e611cb98916c7b03a04b0c8 Mon Sep 17 00:00:00 2001 From: Robert Nagy Date: Mon, 23 Dec 2019 19:11:03 +0100 Subject: [PATCH] fixup: test w/ callback --- benchmark/streams/writable-manywrites.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/benchmark/streams/writable-manywrites.js b/benchmark/streams/writable-manywrites.js index 304b65cd39aa87..78f7aa736f033a 100644 --- a/benchmark/streams/writable-manywrites.js +++ b/benchmark/streams/writable-manywrites.js @@ -6,10 +6,13 @@ const Writable = require('stream').Writable; const bench = common.createBenchmark(main, { n: [2e6], sync: ['yes', 'no'], - writev: ['yes', 'no'] + writev: ['yes', 'no'], + callback: ['yes', 'no'] }); -function main({ n, sync, writev }) { +function nop() {} + +function main({ n, sync, writev, callback }) { const b = Buffer.allocUnsafe(1024); const s = new Writable(); sync = sync === 'yes'; @@ -30,11 +33,13 @@ function main({ n, sync, writev }) { }; } + const cb = callback === 'yes' ? nop : null; + bench.start(); let k = 0; function run() { - while (k++ < n && s.write(b)); + while (k++ < n && s.write(b, cb)); if (k >= n) bench.end(n); }