From 4244b1a0bbaa52db87d06d9950faec784f2a303c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tobias=20Nie=C3=9Fen?= <tniessen@tnie.de>
Date: Sun, 27 Feb 2022 15:05:42 +0100
Subject: [PATCH] src: do not ignore return value of BIO_reset

The USE macro indicates that a value is intentionally ignored. Instead,
CHECK that the function succeeds.

PR-URL: https://github.com/nodejs/node/pull/42103
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
---
 src/crypto/crypto_common.cc | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/crypto/crypto_common.cc b/src/crypto/crypto_common.cc
index 21713f3eb927ef..c7476483925dc6 100644
--- a/src/crypto/crypto_common.cc
+++ b/src/crypto/crypto_common.cc
@@ -298,7 +298,7 @@ Local<Value> ToV8Value(Environment* env, const BIOPointer& bio) {
           mem->data,
           NewStringType::kNormal,
           mem->length);
-  USE(BIO_reset(bio.get()));
+  CHECK_EQ(BIO_reset(bio.get()), 1);
   return ret.FromMaybe(Local<Value>());
 }
 
@@ -951,7 +951,7 @@ v8::MaybeLocal<v8::Value> GetSubjectAltNameString(
   CHECK_NOT_NULL(ext);
 
   if (!SafeX509SubjectAltNamePrint(bio, ext)) {
-    USE(BIO_reset(bio.get()));
+    CHECK_EQ(BIO_reset(bio.get()), 1);
     return v8::Null(env->isolate());
   }
 
@@ -970,7 +970,7 @@ v8::MaybeLocal<v8::Value> GetInfoAccessString(
   CHECK_NOT_NULL(ext);
 
   if (!SafeX509InfoAccessPrint(bio, ext)) {
-    USE(BIO_reset(bio.get()));
+    CHECK_EQ(BIO_reset(bio.get()), 1);
     return v8::Null(env->isolate());
   }
 
@@ -987,7 +987,7 @@ MaybeLocal<Value> GetIssuerString(
           issuer_name,
           0,
           kX509NameFlagsMultiline) <= 0) {
-    USE(BIO_reset(bio.get()));
+    CHECK_EQ(BIO_reset(bio.get()), 1);
     return Undefined(env->isolate());
   }
 
@@ -1003,7 +1003,7 @@ MaybeLocal<Value> GetSubject(
           X509_get_subject_name(cert),
           0,
           kX509NameFlagsMultiline) <= 0) {
-    USE(BIO_reset(bio.get()));
+    CHECK_EQ(BIO_reset(bio.get()), 1);
     return Undefined(env->isolate());
   }