From 3eebd6b17d3d86a7ffb5b5984ac490e9a959c4f3 Mon Sep 17 00:00:00 2001 From: FrankQiu Date: Thu, 2 Sep 2021 20:28:34 +0800 Subject: [PATCH 1/4] doc: add full list of subsystems --- doc/guides/contributing/pull-requests.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 763b05491592d1..8f7ea52a2a1c58 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -579,6 +579,7 @@ If you want to know more about the code review and the landing process, see the * `test` * `tools` +Here is the full list of [subsystems][subsystems]. More than one subsystem may be valid for any particular issue or pull request. [Building guide]: ../../../BUILDING.md @@ -593,3 +594,4 @@ More than one subsystem may be valid for any particular issue or pull request. [https://ci.nodejs.org/]: https://ci.nodejs.org/ [pull request template]: https://raw.githubusercontent.com/nodejs/node/HEAD/.github/PULL_REQUEST_TEMPLATE.md [running tests]: ../../../BUILDING.md#running-tests +[subsystems]: https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js From a6a77795bc587bfbc29f3c8dbc4a70109cacf3be Mon Sep 17 00:00:00 2001 From: FrankQiu Date: Fri, 3 Sep 2021 12:11:56 +0800 Subject: [PATCH 2/4] doc: update doc/guides/contributing/pull-requests.md Co-authored-by: Antoine du Hamel --- doc/guides/contributing/pull-requests.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 8f7ea52a2a1c58..c2829516b018c2 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -579,7 +579,8 @@ If you want to know more about the code review and the landing process, see the * `test` * `tools` -Here is the full list of [subsystems][subsystems]. +You can find the full list of supported subsystems in the +[nodejs/core-validate-commit][] repo. More than one subsystem may be valid for any particular issue or pull request. [Building guide]: ../../../BUILDING.md From 8af6f3fb8029cde9673260444a32fb49ab7d29d7 Mon Sep 17 00:00:00 2001 From: FrankQiu Date: Fri, 3 Sep 2021 12:12:14 +0800 Subject: [PATCH 3/4] doc: update doc/guides/contributing/pull-requests.md Co-authored-by: Antoine du Hamel --- doc/guides/contributing/pull-requests.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index c2829516b018c2..09bb6fb9cc789f 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -595,4 +595,4 @@ More than one subsystem may be valid for any particular issue or pull request. [https://ci.nodejs.org/]: https://ci.nodejs.org/ [pull request template]: https://raw.githubusercontent.com/nodejs/node/HEAD/.github/PULL_REQUEST_TEMPLATE.md [running tests]: ../../../BUILDING.md#running-tests -[subsystems]: https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js +[nodejs/core-validate-commit]: https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js From 318a46adeb672a4667892a81f762ee7854fd8936 Mon Sep 17 00:00:00 2001 From: FrankQiu Date: Fri, 3 Sep 2021 16:27:31 +0800 Subject: [PATCH 4/4] doc: fix lint err --- doc/guides/contributing/pull-requests.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 09bb6fb9cc789f..99e87ef88702ec 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -593,6 +593,6 @@ More than one subsystem may be valid for any particular issue or pull request. [guide for writing tests in Node.js]: ../writing-tests.md [hiding-a-comment]: https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment [https://ci.nodejs.org/]: https://ci.nodejs.org/ +[nodejs/core-validate-commit]: https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js [pull request template]: https://raw.githubusercontent.com/nodejs/node/HEAD/.github/PULL_REQUEST_TEMPLATE.md [running tests]: ../../../BUILDING.md#running-tests -[nodejs/core-validate-commit]: https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js