Skip to content

Commit 4664681

Browse files
MylesBorinsBethGriggs
authored andcommittedDec 15, 2020
tools: don't print gold linker warning w/o flag
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent d027be0 commit 4664681

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed
 

‎configure.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1722,7 +1722,8 @@ def configure_section_file(o):
17221722
proc = subprocess.Popen(['ld.gold'] + ['-v'], stdin = subprocess.PIPE,
17231723
stdout = subprocess.PIPE, stderr = subprocess.PIPE)
17241724
except OSError:
1725-
warn('''No acceptable ld.gold linker found!''')
1725+
if options.node_section_ordering_info != "":
1726+
warn('''No acceptable ld.gold linker found!''')
17261727
return 0
17271728

17281729
match = re.match(r"^GNU gold.*([0-9]+)\.([0-9]+)$",

0 commit comments

Comments
 (0)
Please sign in to comment.