Skip to content

Commit 46f83df

Browse files
richardlauMylesBorins
authored andcommittedApr 2, 2020
build: do not use setup-node in build workflows
The setup-node GitHub Action installs problem matchers that happen to match the warning message format of Visual Studio's C/C++ compiler. This is resulting in all of our pull requests being annotated with `Unchanged files with check annotations` which are confusing to new contributors as they are not due to the changes in the pull request. The action is used to run `npx envinfo` to dump some information into the logs before the actual build. All GitHub hosted runners already have a version of Node.js installed (12.x at the time of this commit) which we can use to run `envinfo`. Remove the action to avoid using the problematic problem matcher. Backport-PR-URL: #32608 PR-URL: #31349 Fixes: #31347 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent ad12c82 commit 46f83df

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed
 

‎.github/workflows/CI.yml

-12
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,6 @@ jobs:
77
runs-on: ubuntu-latest
88
steps:
99
- uses: actions/checkout@v2
10-
- name: Use Node.js 13
11-
uses: actions/setup-node@v1
12-
with:
13-
node-version: 13.x
1410
- name: Environment Information
1511
run: npx envinfo
1612
- name: Build
@@ -19,10 +15,6 @@ jobs:
1915
runs-on: windows-latest
2016
steps:
2117
- uses: actions/checkout@v2
22-
- name: Use Node.js 13
23-
uses: actions/setup-node@v1
24-
with:
25-
node-version: 13.x
2618
- name: Environment Information
2719
run: npx envinfo
2820
- name: Install deps
@@ -33,10 +25,6 @@ jobs:
3325
runs-on: macos-latest
3426
steps:
3527
- uses: actions/checkout@v2
36-
- name: Use Node.js 13
37-
uses: actions/setup-node@v1
38-
with:
39-
node-version: 13.x
4028
- name: Environment Information
4129
run: npx envinfo
4230
- name: Build

0 commit comments

Comments
 (0)
Please sign in to comment.