From 4831278a16d0cbe9e54ba89f1bf4f114aed06e69 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Mon, 7 Sep 2020 15:35:20 +0200 Subject: [PATCH] url: remove U+0000 case in the fragment state Port of https://github.com/whatwg/url/pull/486 PR-URL: https://github.com/nodejs/node/pull/33770 Reviewed-By: Daijiro Wachi Reviewed-By: Shingo Inoue Reviewed-By: Rich Trott Reviewed-By: Joyee Cheung --- src/node_url.cc | 2 -- test/wpt/status/url.json | 3 --- 2 files changed, 5 deletions(-) diff --git a/src/node_url.cc b/src/node_url.cc index bd4932c0ab0c14..8e6906790a3752 100644 --- a/src/node_url.cc +++ b/src/node_url.cc @@ -2084,8 +2084,6 @@ void URL::Parse(const char* input, url->flags |= URL_FLAGS_HAS_FRAGMENT; url->fragment = std::move(buffer); break; - case 0: - break; default: AppendOrEscape(&buffer, ch, FRAGMENT_ENCODE_SET); } diff --git a/test/wpt/status/url.json b/test/wpt/status/url.json index 73f2f3a4aa0126..68181dc41aad71 100644 --- a/test/wpt/status/url.json +++ b/test/wpt/status/url.json @@ -12,9 +12,6 @@ "idlharness.any.js": { "fail": "getter/setter names are wrong, etc." }, - "url-setters-stripping.any.js": { - "fail": "TODO: port https://github.com/whatwg/url/pull/486" - }, "urlsearchparams-constructor.any.js": { "fail": "TODO: fix https://github.com/nodejs/node/issues/33892" },