Skip to content

Commit 49c959d

Browse files
lundibundicodebytere
authored andcommittedFeb 27, 2020
test: increase timeout in vm-timeout-escape-queuemicrotask
It looks like under high load the loop isn't even started and therefore successfully finishes without 'escaping'. After increasing the timeout during parallel run of the test failure rate decreased from 15/1000 to 0/1000. PR-URL: #31966 Refs: #25529 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 6adbfac commit 49c959d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
 

‎test/known_issues/test-vm-timeout-escape-queuemicrotask.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ const NS_PER_MS = 1000000n;
1212

1313
const hrtime = process.hrtime.bigint;
1414

15-
const loopDuration = common.platformTimeout(100n);
16-
const timeout = common.platformTimeout(10);
15+
const loopDuration = common.platformTimeout(1000n);
16+
const timeout = common.platformTimeout(100);
1717

1818
function loop() {
1919
const start = hrtime();

0 commit comments

Comments
 (0)
Please sign in to comment.