From 4a08b85fc8d71ff4e0a669b280dd250f93e5030c Mon Sep 17 00:00:00 2001 From: Matheus Marchini Date: Thu, 12 Mar 2020 15:40:21 -0700 Subject: [PATCH] test: make test-memory-usage predictable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The current test relies on undeterministic behavior from V8 GC, and on newer versions of V8 this test ocasionally fails because that behavior changed. Prevent that from happening using --predictable-gc-schedule. If this test fails in the future, it should fail consistently instead of ocasionally, which should help debug. Ref: https://github.com/nodejs/node-v8/issues/144#issuecomment-597945219 Signed-off-by: Matheus Marchini PR-URL: https://github.com/nodejs/node/pull/32239 Reviewed-By: Anna Henningsen Reviewed-By: Michaël Zasso Reviewed-By: Colin Ihrig Reviewed-By: Jiawen Geng Reviewed-By: Gireesh Punathil --- test/parallel/test-memory-usage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-memory-usage.js b/test/parallel/test-memory-usage.js index abd5bba7bb3f41..e8743c47d235c0 100644 --- a/test/parallel/test-memory-usage.js +++ b/test/parallel/test-memory-usage.js @@ -19,7 +19,7 @@ // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // USE OR OTHER DEALINGS IN THE SOFTWARE. -// Flags: --no-concurrent-array-buffer-freeing +// Flags: --predictable-gc-schedule 'use strict'; const common = require('../common'); const assert = require('assert');