From 4bfbeffec25bccd5ebb96e6f6d3055e8810be3be Mon Sep 17 00:00:00 2001 From: shisama Date: Tue, 28 Apr 2020 23:54:15 +0900 Subject: [PATCH] dns: Add setServers into 'dns/promises' --- lib/dns/promises.js | 4 ++- .../test-dns-setservers-type-check.js | 35 +++++++++++++++++++ 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/lib/dns/promises.js b/lib/dns/promises.js index 35881e5bb47374..ad8a2561ef51e4 100644 --- a/lib/dns/promises.js +++ b/lib/dns/promises.js @@ -1,3 +1,5 @@ 'use strict'; -module.exports = require('internal/dns/promises'); +const dnsPromises = require('internal/dns/promises'); +dnsPromises.setServers = require('dns').setServers; +module.exports = dnsPromises; diff --git a/test/parallel/test-dns-setservers-type-check.js b/test/parallel/test-dns-setservers-type-check.js index 9f09ee4ebf6519..fe05b6c2359c70 100644 --- a/test/parallel/test-dns-setservers-type-check.js +++ b/test/parallel/test-dns-setservers-type-check.js @@ -85,3 +85,38 @@ const promiseResolver = new dns.promises.Resolver(); ); }); } + +// This test for 'dns/promises' +{ + const { + setServers, + resolve + } = require('dns/promises'); + + // This should not throw any error. + (async () => { + const localhost = await resolve('localhost'); + setServers(localhost); + })(); + + [ + [null], + [undefined], + [Number(addresses.DNS4_SERVER)], + [ + { + address: addresses.DNS4_SERVER + } + ] + ].forEach((val) => { + const errObj = { + code: 'ERR_INVALID_ARG_TYPE', + name: 'TypeError', + message: 'The "servers[0]" argument must be of type string.' + + common.invalidArgTypeHelper(val[0]) + }; + assert.throws(() => { + setServers(val); + }, errObj); + }); +}