Skip to content

Commit 4e26831

Browse files
gengjiawentargos
authored andcommittedApr 22, 2020
src: refactor to more safe method
PR-URL: #32087 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 7060ed1 commit 4e26831

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
 

‎src/module_wrap.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -1423,8 +1423,8 @@ static MaybeLocal<Promise> ImportModuleDynamically(
14231423

14241424
Local<PrimitiveArray> options = referrer->GetHostDefinedOptions();
14251425
if (options->Length() != HostDefinedOptions::kLength) {
1426-
Local<Promise::Resolver> resolver =
1427-
Promise::Resolver::New(context).ToLocalChecked();
1426+
Local<Promise::Resolver> resolver;
1427+
if (!Promise::Resolver::New(context).ToLocal(&resolver)) return {};
14281428
resolver
14291429
->Reject(context,
14301430
v8::Exception::TypeError(FIXED_ONE_BYTE_STRING(

0 commit comments

Comments
 (0)
Please sign in to comment.