Skip to content

Commit

Permalink
watch: mark as stable
Browse files Browse the repository at this point in the history
PR-URL: #52074
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
  • Loading branch information
MoLow committed Mar 15, 2024
1 parent 9a1e01c commit 4f68c7c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
11 changes: 9 additions & 2 deletions doc/api/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -2317,14 +2317,17 @@ added:
- v18.11.0
- v16.19.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/52074
description: Watch mode is now stable.
- version:
- v19.2.0
- v18.13.0
pr-url: https://github.com/nodejs/node/pull/45214
description: Test runner now supports running in watch mode.
-->

> Stability: 1 - Experimental
> Stability: 2 - Stable
Starts Node.js in watch mode.
When in watch mode, changes in the watched files cause the Node.js process to
Expand All @@ -2346,9 +2349,13 @@ node --watch index.js
added:
- v18.11.0
- v16.19.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/52074
description: Watch mode is now stable.
-->

> Stability: 1 - Experimental
> Stability: 2 - Stable
Starts Node.js in watch mode and specifies what paths to watch.
When in watch mode, changes in the watched paths cause the Node.js process to
Expand Down
2 changes: 0 additions & 2 deletions lib/internal/main/watch_mode.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ const {
exitCodes: { kNoFailure },
} = internalBinding('errors');
const { getOptionValue } = require('internal/options');
const { emitExperimentalWarning } = require('internal/util');
const { FilesWatcher } = require('internal/watch_mode/files_watcher');
const { green, blue, red, white, clear } = require('internal/util/colors');

Expand Down Expand Up @@ -117,7 +116,6 @@ async function restart() {
}
}

emitExperimentalWarning('Watch mode');
start();
watcher
.on('changed', restart)
Expand Down

0 comments on commit 4f68c7c

Please sign in to comment.