From 50a2af35dbf3c123077b916613cacb2f7cb5647d Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Thu, 11 Feb 2021 00:30:19 +0100 Subject: [PATCH] fixup! doc: update CI requirements for landing pull requests --- doc/guides/collaborator-guide.md | 45 +++++++++++++++++++++++++------- 1 file changed, 35 insertions(+), 10 deletions(-) diff --git a/doc/guides/collaborator-guide.md b/doc/guides/collaborator-guide.md index 1dad0511d46181..f78350aaef36c8 100644 --- a/doc/guides/collaborator-guide.md +++ b/doc/guides/collaborator-guide.md @@ -209,22 +209,47 @@ the comment anyway to avoid any doubt. All fixes must have a test case which demonstrates the defect. The test should fail before the change, and pass after the change. -All pull requests must pass continuous integration tests. Code changes must pass -on [project CI server](). Pull requests that only change -documentation and comments can use GitHub Actions results. - Do not land any pull requests without a passing (green or yellow) CI run. A green GitHub Actions CI result is required. A passing [Jenkins CI](https://ci.nodejs.org/) is also required if PR contains changes -on files in one of the following folders (except it only changes comments): -- `deps/` -- `lib/` -- `src/` -- `test/` +that will affect the `node` binary. This is critical as GitHub Actions CI does +not cover all the environments supported by Node.js. + +
+Changes that affect the `node` binary + +Changes in the following folders (except comment-only changes) are guaranteed to +affect the `node` binary: + +* `deps/` +* `lib/` +* `src/` +* `test/` +* `tools/code_cache/` +* `tools/gyp/` +* `tools/icu/` +* `tools/inspector-protocol/` +* `tools/msvs/` +* `tools/snapshot/` +* `tools/v8_gypfiles/` + +There are some other files that touch the build chain. Changes in the following +files also qualify as affecting the `node` binary: + +* `tools/*.py` +* `tools/build-addons.js` +* `*.gyp` +* `*.gypi` +* `configure` +* `configure.py` +* `Makefile` +* `vcbuilt.bat` + +
If there are GitHub Actions CI failures unrelated to the change in the pull request, try "Re-run all jobs". It's under the "🔄 Re-run jobs" button, on the -right-hand side of "Checks" tab. +right-hand side of "Checks" tab. If there are Jenkins CI failures unrelated to the change in the pull request, try "Resume Build". It is in the left navigation of the relevant