From 554c7c2c987bf105e37fe55534e78911bad9794b Mon Sep 17 00:00:00 2001 From: Matheus Marchini Date: Mon, 9 Dec 2019 11:26:07 -0800 Subject: [PATCH] deps: V8: cherry-pick cc5016e1b702 Original commit message: [postmortem] add metadata for the new DescriptorArray layout R=yangguo@chromium.org Ref: https://github.com/nodejs/llnode/issues/255 Change-Id: Icda271123375db5c381fe1d1bba13dcc26f26d7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832311 Reviewed-by: Yang Guo Commit-Queue: Yang Guo Cr-Commit-Position: refs/heads/master@{#64169} Refs: https://github.com/v8/v8/commit/cc5016e1b702c9dc27d3730ce1717b4d69e433f9 PR-URL: https://github.com/nodejs/node/pull/30870 Reviewed-By: Michael Dawson --- common.gypi | 2 +- deps/v8/BUILD.gn | 2 ++ deps/v8/tools/gen-postmortem-metadata.py | 4 +++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index 36047fcb91d768..b8c1e9fabb26d2 100644 --- a/common.gypi +++ b/common.gypi @@ -38,7 +38,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.27', + 'v8_embedder_string': '-node.28', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/BUILD.gn b/deps/v8/BUILD.gn index a026749a31db52..90ec4097d7a2b8 100644 --- a/deps/v8/BUILD.gn +++ b/deps/v8/BUILD.gn @@ -895,6 +895,8 @@ action("postmortem-metadata") { "src/objects/code.h", "src/objects/data-handler.h", "src/objects/data-handler-inl.h", + "src/objects/descriptor-array.h", + "src/objects/descriptor-array-inl.h", "src/objects/feedback-cell.h", "src/objects/feedback-cell-inl.h", "src/objects/fixed-array-inl.h", diff --git a/deps/v8/tools/gen-postmortem-metadata.py b/deps/v8/tools/gen-postmortem-metadata.py index ceaf7798fd32c2..ee167ec37e67bb 100644 --- a/deps/v8/tools/gen-postmortem-metadata.py +++ b/deps/v8/tools/gen-postmortem-metadata.py @@ -286,6 +286,7 @@ 'Code, instruction_start, uintptr_t, kHeaderSize', 'Code, instruction_size, int, kInstructionSizeOffset', 'String, length, int32_t, kLengthOffset', + 'DescriptorArray, header_size, uintptr_t, kHeaderSize', ]; # @@ -296,7 +297,8 @@ expected_classes = [ 'ConsString', 'FixedArray', 'HeapNumber', 'JSArray', 'JSFunction', 'JSObject', 'JSRegExp', 'JSPrimitiveWrapper', 'Map', 'Oddball', 'Script', - 'SeqOneByteString', 'SharedFunctionInfo', 'ScopeInfo', 'JSPromise' + 'SeqOneByteString', 'SharedFunctionInfo', 'ScopeInfo', 'JSPromise', + 'DescriptorArray' ];