Skip to content

Commit 570bef1

Browse files
addaleaxBethGriggs
authored andcommittedSep 21, 2021
Revert "src: skip test_fatal/test_threads for Debug builds"
This reverts commit 1fc4d43. PR-URL: #39954 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 842f936 commit 570bef1

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed
 

‎test/node-api/test_fatal/test_threads.js

-4
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@ const assert = require('assert');
44
const child_process = require('child_process');
55
const test_fatal = require(`./build/${common.buildType}/test_fatal`);
66

7-
if (common.buildType === 'Debug')
8-
common.skip('as this will currently fail with a Debug check ' +
9-
'in v8::Isolate::GetCurrent()');
10-
117
// Test in a child process because the test code will trigger a fatal error
128
// that crashes the process.
139
if (process.argv[2] === 'child') {

0 commit comments

Comments
 (0)
Please sign in to comment.