From 570bef17104a861b2c9cf2cbd13fcd5828d7532a Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Tue, 31 Aug 2021 12:43:45 +0200 Subject: [PATCH] Revert "src: skip test_fatal/test_threads for Debug builds" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 1fc4d43a3255273709f5fcb51bb0c5b0407de4ac. PR-URL: https://github.com/nodejs/node/pull/39954 Reviewed-By: Michaël Zasso Reviewed-By: Tobias Nießen Reviewed-By: Darshan Sen Reviewed-By: James M Snell Reviewed-By: Colin Ihrig --- test/node-api/test_fatal/test_threads.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/node-api/test_fatal/test_threads.js b/test/node-api/test_fatal/test_threads.js index 6f6dc772d18252..fd56f60cbe832f 100644 --- a/test/node-api/test_fatal/test_threads.js +++ b/test/node-api/test_fatal/test_threads.js @@ -4,10 +4,6 @@ const assert = require('assert'); const child_process = require('child_process'); const test_fatal = require(`./build/${common.buildType}/test_fatal`); -if (common.buildType === 'Debug') - common.skip('as this will currently fail with a Debug check ' + - 'in v8::Isolate::GetCurrent()'); - // Test in a child process because the test code will trigger a fatal error // that crashes the process. if (process.argv[2] === 'child') {