Skip to content

Commit 57badcf

Browse files
cjihrigBethGriggs
authored andcommittedSep 8, 2020
deps: libuv: cherry-pick 0e6e8620
Original commit message: unix: don't use _POSIX_PATH_MAX Libuv was using _POSIX_PATH_MAX wrong. Bug introduced in commit b56d279b ("unix: do not require PATH_MAX to be defined") from September 2018. _POSIX_PATH_MAX is the minimum max path size guaranteed by POSIX, not the actual max path size of the system libuv runs on. _POSIX_PATH_MAX is always 256, the real max is often much bigger. This commit fixes buffer overruns when processing very long paths in uv_fs_readlink() and uv_fs_realpath() because libuv was not allocating enough memory to store the result. Fixes: libuv/libuv#2965 PR-URL: libuv/libuv#2966 Backport-PR-URL: nodejs-private/node-private#221 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jameson Nash <vtjnash@gmail.com>
1 parent f38bcc2 commit 57badcf

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed
 

‎deps/uv/src/unix/internal.h

+1-3
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,7 @@
6161
# include <AvailabilityMacros.h>
6262
#endif
6363

64-
#if defined(_POSIX_PATH_MAX)
65-
# define UV__PATH_MAX _POSIX_PATH_MAX
66-
#elif defined(PATH_MAX)
64+
#if defined(PATH_MAX)
6765
# define UV__PATH_MAX PATH_MAX
6866
#else
6967
# define UV__PATH_MAX 8192

0 commit comments

Comments
 (0)
Please sign in to comment.