From 57ff476c339b08e9a144af38661872ec12d9aead Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Sun, 31 Jul 2022 13:46:06 +0200 Subject: [PATCH] test: remove duplicate test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `test/parallel/test-http-agent-no-wait.js` is basically a duplicate of `test/parallel/test-http-client-close-with-default-agent.js`, remove it. PR-URL: https://github.com/nodejs/node/pull/44051 Reviewed-By: Paolo Insogna Reviewed-By: Feng Yu Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel --- test/parallel/test-http-agent-no-wait.js | 24 ------------------- ...st-http-client-close-with-default-agent.js | 2 +- 2 files changed, 1 insertion(+), 25 deletions(-) delete mode 100644 test/parallel/test-http-agent-no-wait.js diff --git a/test/parallel/test-http-agent-no-wait.js b/test/parallel/test-http-agent-no-wait.js deleted file mode 100644 index 62a381e85ce07c..00000000000000 --- a/test/parallel/test-http-agent-no-wait.js +++ /dev/null @@ -1,24 +0,0 @@ -'use strict'; - -const common = require('../common'); -const assert = require('assert'); -const http = require('http'); - -const server = http.createServer(function(req, res) { - res.writeHead(200); - res.end(); -}); - -server.listen(0, common.mustCall(() => { - const req = http.get({ port: server.address().port }, (res) => { - assert.strictEqual(res.statusCode, 200); - - res.resume(); - server.close(); - }); - - req.end(); -})); - -// This timer should never go off as the server will close the socket -setTimeout(common.mustNotCall(), 1000).unref(); diff --git a/test/parallel/test-http-client-close-with-default-agent.js b/test/parallel/test-http-client-close-with-default-agent.js index 8973f454e37728..ea1e1481baaa7b 100644 --- a/test/parallel/test-http-client-close-with-default-agent.js +++ b/test/parallel/test-http-client-close-with-default-agent.js @@ -20,4 +20,4 @@ server.listen(0, common.mustCall(() => { })); // This timer should never go off as the server will close the socket -setTimeout(common.mustNotCall(), common.platformTimeout(10000)).unref(); +setTimeout(common.mustNotCall(), common.platformTimeout(1000)).unref();