From 587367d1079156731f4475d23dede91e43d224eb Mon Sep 17 00:00:00 2001
From: legendecas <legendecas@gmail.com>
Date: Thu, 15 Sep 2022 02:06:23 +0800
Subject: [PATCH] perf_hooks: expose webperf global scope interfaces

Exposes `PerformanceEntry`, `PerformanceMark`, `PerformanceMeasure`,
`PerformanceObserver`, `PerformanceObserverEntryList`,
and `PerformanceResourceTiming` to the global scope.

PR-URL: https://github.com/nodejs/node/pull/44483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 doc/api/globals.md                    | 68 +++++++++++++++++++++++++++
 lib/.eslintrc.yaml                    | 12 +++++
 lib/internal/bootstrap/browser.js     |  6 +++
 test/wpt/test-performance-timeline.js | 24 ----------
 test/wpt/test-resource-timing.js      | 17 -------
 test/wpt/test-user-timing.js          | 32 -------------
 6 files changed, 86 insertions(+), 73 deletions(-)

diff --git a/doc/api/globals.md b/doc/api/globals.md
index 71e9a400cbdb4d..2e5d2fe7515123 100644
--- a/doc/api/globals.md
+++ b/doc/api/globals.md
@@ -541,6 +541,68 @@ The `MessagePort` class. See [`MessagePort`][] for more details.
 
 This variable may appear to be global but is not. See [`module`][].
 
+## `PerformanceEntry`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+<!-- type=global -->
+
+The `PerformanceEntry` class. See [`PerformanceEntry`][] for more details.
+
+## `PerformanceMark`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+<!-- type=global -->
+
+The `PerformanceMark` class. See [`PerformanceMark`][] for more details.
+
+## `PerformanceMeasure`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+<!-- type=global -->
+
+The `PerformanceMeasure` class. See [`PerformanceMeasure`][] for more details.
+
+## `PerformanceObserver`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+<!-- type=global -->
+
+The `PerformanceObserver` class. See [`PerformanceObserver`][] for more details.
+
+## `PerformanceObserverEntryList`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+<!-- type=global -->
+
+The `PerformanceObserverEntryList` class. See
+[`PerformanceObserverEntryList`][] for more details.
+
+## `PerformanceResourceTiming`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+<!-- type=global -->
+
+The `PerformanceResourceTiming` class. See [`PerformanceResourceTiming`][] for
+more details.
+
 ## `performance`
 
 <!-- YAML
@@ -899,6 +961,12 @@ A browser-compatible implementation of [`WritableStreamDefaultWriter`][].
 [`MessageChannel`]: worker_threads.md#class-messagechannel
 [`MessageEvent`]: https://developer.mozilla.org/en-US/docs/Web/API/MessageEvent/MessageEvent
 [`MessagePort`]: worker_threads.md#class-messageport
+[`PerformanceEntry`]: perf_hooks.md#class-performanceentry
+[`PerformanceMark`]: perf_hooks.md#class-performancemark
+[`PerformanceMeasure`]: perf_hooks.md#class-performancemeasure
+[`PerformanceObserverEntryList`]: perf_hooks.md#class-performanceobserverentrylist
+[`PerformanceObserver`]: perf_hooks.md#class-performanceobserver
+[`PerformanceResourceTiming`]: perf_hooks.md#class-performanceresourcetiming
 [`ReadableByteStreamController`]: webstreams.md#class-readablebytestreamcontroller
 [`ReadableStreamBYOBReader`]: webstreams.md#class-readablestreambyobreader
 [`ReadableStreamBYOBRequest`]: webstreams.md#class-readablestreambyobrequest
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
index 2cfbf0894f2a3a..f1c3b98de4edd7 100644
--- a/lib/.eslintrc.yaml
+++ b/lib/.eslintrc.yaml
@@ -73,6 +73,18 @@ rules:
       message: Use `const { MessageEvent } = require('internal/worker/io');` instead of the global.
     - name: MessagePort
       message: Use `const { MessagePort } = require('internal/worker/io');` instead of the global.
+    - name: PerformanceEntry
+      message: Use `const { PerformanceEntry } = require('perf_hooks');` instead of the global.
+    - name: PerformanceMark
+      message: Use `const { PerformanceMark } = require('perf_hooks');` instead of the global.
+    - name: PerformanceMeasure
+      message: Use `const { PerformanceMeasure } = require('perf_hooks');` instead of the global.
+    - name: PerformanceObserverEntryList
+      message: Use `const { PerformanceObserverEntryList } = require('perf_hooks');` instead of the global.
+    - name: PerformanceObserver
+      message: Use `const { PerformanceObserver } = require('perf_hooks');` instead of the global.
+    - name: PerformanceResourceTiming
+      message: Use `const { PerformanceResourceTiming } = require('perf_hooks');` instead of the global.
     - name: ReadableStream
       message: Use `const { ReadableStream } = require('internal/webstreams/readablestream')` instead of the global.
     - name: ReadableStreamDefaultReader
diff --git a/lib/internal/bootstrap/browser.js b/lib/internal/bootstrap/browser.js
index 92d57688e21115..b4125f1b54f99e 100644
--- a/lib/internal/bootstrap/browser.js
+++ b/lib/internal/bootstrap/browser.js
@@ -75,6 +75,12 @@ exposeInterface(globalThis, 'Blob', buffer.Blob);
 // https://www.w3.org/TR/hr-time-2/#the-performance-attribute
 const perf_hooks = require('perf_hooks');
 exposeInterface(globalThis, 'Performance', perf_hooks.Performance);
+exposeInterface(globalThis, 'PerformanceEntry', perf_hooks.PerformanceEntry);
+exposeInterface(globalThis, 'PerformanceMark', perf_hooks.PerformanceMark);
+exposeInterface(globalThis, 'PerformanceMeasure', perf_hooks.PerformanceMeasure);
+exposeInterface(globalThis, 'PerformanceObserver', perf_hooks.PerformanceObserver);
+exposeInterface(globalThis, 'PerformanceObserverEntryList', perf_hooks.PerformanceObserverEntryList);
+exposeInterface(globalThis, 'PerformanceResourceTiming', perf_hooks.PerformanceResourceTiming);
 defineReplaceableAttribute(globalThis, 'performance',
                            perf_hooks.performance);
 
diff --git a/test/wpt/test-performance-timeline.js b/test/wpt/test-performance-timeline.js
index 1d5a259c769d99..89dfcaf5755bb2 100644
--- a/test/wpt/test-performance-timeline.js
+++ b/test/wpt/test-performance-timeline.js
@@ -7,30 +7,6 @@ const runner = new WPTRunner('performance-timeline');
 runner.pretendGlobalThisAs('Window');
 runner.brandCheckGlobalScopeAttribute('performance');
 runner.setInitScript(`
-  const {
-    PerformanceEntry,
-    PerformanceObserver,
-    PerformanceObserverEntryList,
-  } = require('perf_hooks');
-  Object.defineProperty(global, 'PerformanceEntry', {
-    value: PerformanceEntry,
-    enumerable: false,
-    writable: true,
-    configurable: true,
-  });
-  Object.defineProperty(global, 'PerformanceObserver', {
-    value: PerformanceObserver,
-    enumerable: false,
-    writable: true,
-    configurable: true,
-  });
-  Object.defineProperty(global, 'PerformanceObserverEntryList', {
-    value: PerformanceObserverEntryList,
-    enumerable: false,
-    writable: true,
-    configurable: true,
-  });
-
   // Create a dummy resource timing entry to mimic how the browser would
   // record the initial page load.
   performance.markResourceTiming({
diff --git a/test/wpt/test-resource-timing.js b/test/wpt/test-resource-timing.js
index ea383f73b6d881..881888b1fd601c 100644
--- a/test/wpt/test-resource-timing.js
+++ b/test/wpt/test-resource-timing.js
@@ -6,23 +6,6 @@ const runner = new WPTRunner('resource-timing');
 
 runner.pretendGlobalThisAs('Window');
 runner.setInitScript(`
-  const {
-    PerformanceEntry,
-    PerformanceResourceTiming,
-  } = require('perf_hooks');
-  Object.defineProperty(global, 'PerformanceEntry', {
-    value: PerformanceEntry,
-    enumerable: false,
-    writable: true,
-    configurable: true,
-  });
-  Object.defineProperty(global, 'PerformanceResourceTiming', {
-    value: PerformanceResourceTiming,
-    enumerable: false,
-    writable: true,
-    configurable: true,
-  });
-
   global.resource = performance.markResourceTiming({
     startTime: 0,
     endTime: 0,
diff --git a/test/wpt/test-user-timing.js b/test/wpt/test-user-timing.js
index f82d2411c3ece2..8c3c3812430514 100644
--- a/test/wpt/test-user-timing.js
+++ b/test/wpt/test-user-timing.js
@@ -7,37 +7,5 @@ const runner = new WPTRunner('user-timing');
 
 runner.pretendGlobalThisAs('Window');
 runner.brandCheckGlobalScopeAttribute('performance');
-runner.setInitScript(`
-  const {
-    PerformanceEntry,
-    PerformanceMark,
-    PerformanceMeasure,
-    PerformanceObserver,
-  } = require('perf_hooks');
-  Object.defineProperty(global, 'PerformanceEntry', {
-    value: PerformanceEntry,
-    enumerable: false,
-    writable: true,
-    configurable: true,
-  });
-  Object.defineProperty(global, 'PerformanceMark', {
-    value: PerformanceMark,
-    enumerable: false,
-    writable: true,
-    configurable: true,
-  });
-  Object.defineProperty(global, 'PerformanceMeasure', {
-    value: PerformanceMeasure,
-    enumerable: false,
-    writable: true,
-    configurable: true,
-  });
-  Object.defineProperty(global, 'PerformanceObserver', {
-    value: PerformanceObserver,
-    enumerable: false,
-    writable: true,
-    configurable: true,
-  });
-`);
 
 runner.runJsTests();