From 5ac21bceba432bf85aebeae1416794514a66ed63 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Mon, 21 Dec 2020 17:44:23 +0000 Subject: [PATCH] tools: fix make-v8.sh MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit V8's `tools/dev/v8gen.py` does not like being passed an empty string (`""`). PR-URL: https://github.com/nodejs/node/pull/36594 Refs: https://github.com/nodejs/node/pull/36099 Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Ben Coe Reviewed-By: Jiawen Geng --- tools/make-v8.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/make-v8.sh b/tools/make-v8.sh index 6b09b515c3de2c..5a23432b589001 100755 --- a/tools/make-v8.sh +++ b/tools/make-v8.sh @@ -36,6 +36,7 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then gn gen -v "out.gn/$BUILD_ARCH_TYPE" --args="is_component_build=false is_debug=false use_goma=false goma_dir=\"None\" use_custom_libcxx=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\" v8_enable_backtrace=true" ninja -v -C "out.gn/$BUILD_ARCH_TYPE" d8 cctest inspector-test else - PATH=~/_depot_tools:$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" --no-goma "$V8_BUILD_OPTIONS" + # shellcheck disable=SC2086 + PATH=~/_depot_tools:$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" --no-goma $V8_BUILD_OPTIONS PATH=~/_depot_tools:$PATH ninja -C "out.gn/$BUILD_ARCH_TYPE/" d8 cctest inspector-test fi