Skip to content

Commit 5d4d584

Browse files
ShogunPandaRafaelGSS
authored andcommittedApr 2, 2024
http: do not allow OBS fold in headers by default
PR-URL: nodejs-private/node-private#558 Refs: nodejs-private/node-private#556 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> CVE-ID: CVE-2024-27982
1 parent 60d2493 commit 5d4d584

File tree

5 files changed

+456
-420
lines changed

5 files changed

+456
-420
lines changed
 

‎deps/llhttp/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
cmake_minimum_required(VERSION 3.5.1)
22
cmake_policy(SET CMP0069 NEW)
33

4-
project(llhttp VERSION 6.1.0)
4+
project(llhttp VERSION 6.1.1)
55
include(GNUInstallDirs)
66

77
set(CMAKE_C_STANDARD 99)

‎deps/llhttp/include/llhttp.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
#define LLHTTP_VERSION_MAJOR 6
55
#define LLHTTP_VERSION_MINOR 1
6-
#define LLHTTP_VERSION_PATCH 0
6+
#define LLHTTP_VERSION_PATCH 1
77

88
#ifndef LLHTTP_STRICT_MODE
99
# define LLHTTP_STRICT_MODE 0

‎deps/llhttp/src/llhttp.c

+451-413
Large diffs are not rendered by default.

‎test/parallel/test-http-multi-line-headers.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ const server = net.createServer(function(conn) {
4646
server.listen(0, common.mustCall(function() {
4747
http.get({
4848
host: '127.0.0.1',
49-
port: this.address().port
49+
port: this.address().port,
50+
insecureHTTPParser: true
5051
}, common.mustCall(function(res) {
5152
assert.strictEqual(res.headers['content-type'],
5253
'text/plain; x-unix-mode=0600; name="hello.txt"');

‎test/parallel/test-http-transfer-encoding-smuggling.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,7 @@ const net = require('net');
7171
'',
7272
].join('\r\n');
7373

74-
const server = http.createServer(common.mustCall((request, response) => {
75-
assert.notStrictEqual(request.url, '/admin');
76-
response.end('hello world');
77-
}), 1);
74+
const server = http.createServer(common.mustNotCall());
7875

7976
server.listen(0, common.mustSucceed(() => {
8077
const client = net.connect(server.address().port, 'localhost');

0 commit comments

Comments
 (0)
Please sign in to comment.