From 5d80576889f278d8ec5cc31f96dd35e269d775e8 Mon Sep 17 00:00:00 2001
From: Thomas <hakerh403@gmail.com>
Date: Tue, 28 Apr 2020 19:15:36 +0200
Subject: [PATCH] errors: skip fatal error highlighting on windows

Some consoles do not convert ANSI escape sequences to colors,
rather display them directly to the stdout. On those consoles,
libuv emulates colors by intercepting stdout stream and calling
corresponding Windows API functions for setting console colors.
However, fatal error are handled differently and we cannot easily
highlight them.

PR-URL: https://github.com/nodejs/node/pull/33132
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
---
 lib/internal/errors.js | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/lib/internal/errors.js b/lib/internal/errors.js
index 48295b2744146f..1e987cefb156df 100644
--- a/lib/internal/errors.js
+++ b/lib/internal/errors.js
@@ -669,15 +669,31 @@ const fatalExceptionStackEnhancers = {
   },
   afterInspector(error) {
     const originalStack = error.stack;
+    let useColors = true;
+    // Some consoles do not convert ANSI escape sequences to colors,
+    // rather display them directly to the stdout. On those consoles,
+    // libuv emulates colors by intercepting stdout stream and calling
+    // corresponding Windows API functions for setting console colors.
+    // However, fatal error are handled differently and we cannot easily
+    // highlight them. On Windows, detecting whether a console supports
+    // ANSI escape sequences is not reliable.
+    if (process.platform === 'win32') {
+      const info = internalBinding('os').getOSInformation();
+      const ver = info[2].split('.').map((a) => +a);
+      if (ver[0] !== 10 || ver[2] < 14393) {
+        useColors = false;
+      }
+    }
     const {
       inspect,
       inspectDefaultOptions: {
         colors: defaultColors
       }
     } = lazyInternalUtilInspect();
-    const colors = (internalBinding('util').guessHandleType(2) === 'TTY' &&
+    const colors = useColors &&
+                   ((internalBinding('util').guessHandleType(2) === 'TTY' &&
                    require('internal/tty').hasColors()) ||
-                   defaultColors;
+                   defaultColors);
     try {
       return inspect(error, { colors });
     } catch {