Skip to content

Commit 5f3f3a5

Browse files
GeoffreyBoothdanielleadams
authored andcommittedOct 12, 2021
v8: remove --harmony-top-level-await
PR-URL: #40226 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 3743406 commit 5f3f3a5

File tree

5 files changed

+0
-28
lines changed

5 files changed

+0
-28
lines changed
 

‎src/node.cc

-7
Original file line numberDiff line numberDiff line change
@@ -803,13 +803,6 @@ int ProcessGlobalArgs(std::vector<std::string>* args,
803803
return 12;
804804
}
805805

806-
// TODO(mylesborins): remove this when the harmony-top-level-await flag
807-
// is removed in V8
808-
if (std::find(v8_args.begin(), v8_args.end(),
809-
"--no-harmony-top-level-await") == v8_args.end()) {
810-
v8_args.push_back("--harmony-top-level-await");
811-
}
812-
813806
auto env_opts = per_process::cli_options->per_isolate->per_env;
814807
if (std::find(v8_args.begin(), v8_args.end(),
815808
"--abort-on-uncaught-exception") != v8_args.end() ||

‎test/message/esm_display_syntax_error.mjs

-4
This file was deleted.

‎test/message/esm_display_syntax_error.out

-8
This file was deleted.

‎test/parallel/test-no-harmony-top-level-await.mjs

-8
This file was deleted.

‎tools/code_cache/mkcodecache.cc

-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ int main(int argc, char* argv[]) {
2828
#endif // _WIN32
2929

3030
v8::V8::SetFlagsFromString("--random_seed=42");
31-
v8::V8::SetFlagsFromString("--harmony-top-level-await");
3231

3332
if (argc < 2) {
3433
std::cerr << "Usage: " << argv[0] << " <path/to/output.cc>\n";

0 commit comments

Comments
 (0)
Please sign in to comment.