From 60c2a863da902f8632f80b5be04ea858858e7693 Mon Sep 17 00:00:00 2001 From: Yagiz Nizipli Date: Thu, 2 Feb 2023 12:53:20 -0500 Subject: [PATCH] src: use string_view instead of std::string& PR-URL: https://github.com/nodejs/node/pull/46471 Reviewed-By: Anna Henningsen Reviewed-By: Rafael Gonzaga Reviewed-By: James M Snell --- src/inspector/main_thread_interface.cc | 2 +- src/inspector/main_thread_interface.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/inspector/main_thread_interface.cc b/src/inspector/main_thread_interface.cc index 23c34da7f58573..3a673e021126aa 100644 --- a/src/inspector/main_thread_interface.cc +++ b/src/inspector/main_thread_interface.cc @@ -289,7 +289,7 @@ Deletable* MainThreadInterface::GetObjectIfExists(int id) { return iterator->second.get(); } -std::unique_ptr Utf8ToStringView(const std::string& message) { +std::unique_ptr Utf8ToStringView(const std::string_view message) { size_t expected_u16_length = simdutf::utf16_length_from_utf8(message.data(), message.length()); MaybeStackBuffer buffer(expected_u16_length); diff --git a/src/inspector/main_thread_interface.h b/src/inspector/main_thread_interface.h index 3ec5b3db3e1600..71989db3bcacb9 100644 --- a/src/inspector/main_thread_interface.h +++ b/src/inspector/main_thread_interface.h @@ -34,7 +34,7 @@ class Deletable { }; std::unique_ptr Utf8ToStringView( - const std::string& message); + const std::string_view message); using MessageQueue = std::deque>;