Skip to content

Commit 60db455

Browse files
gireeshpunathilrvagg
authored andcommittedFeb 28, 2019
test: mark test_threadsafe_function/test as flaky
The test fails consistently on windows-fanned with vs2017. mark it as flaky while the issue is being progressed, and to keep CI green / amber. Ref: #23621 Backport-PR-URL: #25002 PR-URL: #24714 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent fe43282 commit 60db455

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed
 

‎test/addons-napi/addons-napi.status

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
prefix addons-napi
2+
3+
# To mark a test as flaky, list the test name in the appropriate section
4+
# below, without ".js", followed by ": PASS,FLAKY". Example:
5+
# sample-test : PASS,FLAKY
6+
7+
[true] # This section applies to all platforms
8+
9+
[$system==win32]
10+
# https://github.com/nodejs/node/issues/23621
11+
test_threadsafe_function/test: PASS,FLAKY

0 commit comments

Comments
 (0)
Please sign in to comment.