From 60db455961477244c6ca4fcf17bcd2c2e90820ca Mon Sep 17 00:00:00 2001 From: Gireesh Punathil Date: Thu, 29 Nov 2018 10:26:53 +0530 Subject: [PATCH] test: mark test_threadsafe_function/test as flaky The test fails consistently on windows-fanned with vs2017. mark it as flaky while the issue is being progressed, and to keep CI green / amber. Ref: https://github.com/nodejs/node/issues/23621 Backport-PR-URL: https://github.com/nodejs/node/pull/25002 PR-URL: https://github.com/nodejs/node/pull/24714 Reviewed-By: James M Snell Reviewed-By: Rich Trott --- test/addons-napi/addons-napi.status | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 test/addons-napi/addons-napi.status diff --git a/test/addons-napi/addons-napi.status b/test/addons-napi/addons-napi.status new file mode 100644 index 00000000000000..dffcf3787bfe47 --- /dev/null +++ b/test/addons-napi/addons-napi.status @@ -0,0 +1,11 @@ +prefix addons-napi + +# To mark a test as flaky, list the test name in the appropriate section +# below, without ".js", followed by ": PASS,FLAKY". Example: +# sample-test : PASS,FLAKY + +[true] # This section applies to all platforms + +[$system==win32] +# https://github.com/nodejs/node/issues/23621 +test_threadsafe_function/test: PASS,FLAKY