Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
doc: improve best practices in onboarding-extras
PR-URL: #19315
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
  • Loading branch information
Trott authored and BethGriggs committed Oct 17, 2018
1 parent afcf059 commit 610297e
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions doc/onboarding-extras.md
Expand Up @@ -130,10 +130,7 @@ to update from nodejs/node:
* `git remote update -p` OR `git fetch --all` (I prefer the former)
* `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`)

## Best practices

## best practices

* commit often, out to your github fork (origin), open a PR
* when making PRs make sure to spend time on the description:
* every moment you spend writing a good description quarters the amount of time it takes to understand your code.
* usually prefer to only squash at the *end* of your work, depends on the change
* When making PRs, spend time writing a thorough description.
* Usually only squash at the end of your work.

0 comments on commit 610297e

Please sign in to comment.