From 610297e2aba3e9d2118e5fcdc1cc0f1bd40fea77 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 12 Mar 2018 22:03:19 -0700 Subject: [PATCH] doc: improve best practices in onboarding-extras MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/19315 Reviewed-By: Daniel Bevenius Reviewed-By: Michaël Zasso Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau --- doc/onboarding-extras.md | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md index 0da3b1b5259f3a..75f3010be48b2e 100644 --- a/doc/onboarding-extras.md +++ b/doc/onboarding-extras.md @@ -130,10 +130,7 @@ to update from nodejs/node: * `git remote update -p` OR `git fetch --all` (I prefer the former) * `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`) +## Best practices -## best practices - -* commit often, out to your github fork (origin), open a PR -* when making PRs make sure to spend time on the description: - * every moment you spend writing a good description quarters the amount of time it takes to understand your code. -* usually prefer to only squash at the *end* of your work, depends on the change +* When making PRs, spend time writing a thorough description. +* Usually only squash at the end of your work.