From 61886507ce0bf4862f38c46547dd5c42a7e9bd0a Mon Sep 17 00:00:00 2001
From: Ruben Bridgewater <ruben@bridgewater.de>
Date: Tue, 10 Dec 2019 18:17:01 +0100
Subject: [PATCH] repl: simplify code
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This simplifies some repl code and removes a code branch that is
unreachable.

PR-URL: https://github.com/nodejs/node/pull/30907
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
---
 lib/repl.js | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/lib/repl.js b/lib/repl.js
index bcbe3a292df910..4c44833699453a 100644
--- a/lib/repl.js
+++ b/lib/repl.js
@@ -965,7 +965,7 @@ REPLServer.prototype.createContext = function() {
   }
 
   const module = new CJSModule('<repl>');
-  module.paths = CJSModule._resolveLookupPaths('<repl>', parentModule) || [];
+  module.paths = CJSModule._resolveLookupPaths('<repl>', parentModule);
 
   ObjectDefineProperty(context, 'module', {
     configurable: true,
@@ -1321,21 +1321,17 @@ function complete(line, callback) {
             }
             // Works for non-objects
             try {
-              let sentinel = 5;
               let p;
               if (typeof obj === 'object' || typeof obj === 'function') {
                 p = ObjectGetPrototypeOf(obj);
               } else {
                 p = obj.constructor ? obj.constructor.prototype : null;
               }
-              while (p !== null) {
+              // Circular refs possible? Let's guard against that.
+              let sentinel = 5;
+              while (p !== null && sentinel-- !== 0) {
                 memberGroups.push(filteredOwnPropertyNames(p));
                 p = ObjectGetPrototypeOf(p);
-                // Circular refs possible? Let's guard against that.
-                sentinel--;
-                if (sentinel <= 0) {
-                  break;
-                }
               }
             } catch {}
           }