From 6327685363dfd0625cf29996763eebf732abdbe3 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 30 Nov 2021 06:22:52 -0800 Subject: [PATCH] build: fail early in test-macos.yml MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/41035 Reviewed-By: James M Snell Reviewed-By: Michaël Zasso --- .github/workflows/test-macos.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/test-macos.yml b/.github/workflows/test-macos.yml index 7da25a825871fd..bdea886801a784 100644 --- a/.github/workflows/test-macos.yml +++ b/.github/workflows/test-macos.yml @@ -43,6 +43,14 @@ jobs: python-version: ${{ env.PYTHON_VERSION }} - name: Environment Information run: npx envinfo + # The `npm ci` for this step fails a lot as part of the Test step. Run it + # now so that we don't have to wait 2 hours for the Build step to pass + # first before that failure happens. (And if there's something about + # `make run-ci -j2` that is causing the failure and the failure doesn't + # happen anymore running this step here first, that's also useful + # information.) + - name: tools/doc/node_modules workaround + run: make tools/doc/node_modules - name: Build run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn" - name: Test