From 63ad918c0a254d050a2c2dc7c28a55ec571fdde5 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 26 Feb 2021 05:38:03 -0800 Subject: [PATCH] doc: revise objections section of collaborator guide The bold text is overused in this section. This change removes it. It also changes some wording: PR -> pull request, can -> may in a rare instance where "may" is the right choice in our docs, etc. (The recommendation to avoid "may" is because "may" implies permission rather than just ability. Yes, I'm probably the one that changed it from "may" in the first place.) --- doc/guides/collaborator-guide.md | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/doc/guides/collaborator-guide.md b/doc/guides/collaborator-guide.md index 8629f4b6653725..bba449752ac588 100644 --- a/doc/guides/collaborator-guide.md +++ b/doc/guides/collaborator-guide.md @@ -153,21 +153,21 @@ requirements. If a pull request meets all requirements except the #### Objections -**Collaborators can object to a pull request by using the "Request -Changes" GitHub feature**. Dissent comments alone don't constitute an -objection. **Any PR objection must include a clear reason for that objection, -and the objector must remain responsive for further discussion towards -consensus about the direction of the pull request**. Providing a set of -actionable steps alongside the objection is recommended. +Collaborators can object to a pull request by using the "Request +Changes" GitHub feature. Dissent comments alone don't constitute an +objection. Any pull request objection must include a clear reason for that +objection, and the objector must remain responsive for further discussion +towards consensus about the direction of the pull request. Where possible, +provide a set of actionable steps alongside the objection. If the objection is not clear to others, another collaborator can ask an objecting collaborator to explain their objection or to provide actionable -steps to resolve the objection. **If the objector is unresponsive for seven -days after a collaborator asks for clarification, another collaborator can -dismiss the objection**. +steps to resolve the objection. If the objector is unresponsive for seven +days after a collaborator asks for clarification, a collaborator may +dismiss the objection. -**Pull requests with outstanding objections must remain open until all -objections are satisfied**. If reaching consensus is not possible, a +Pull requests with outstanding objections must remain open until all +objections are satisfied. If reaching consensus is not possible, a collaborator can escalate the issue to the TSC by pinging `@nodejs/tsc` and adding the `tsc-agenda` label to the issue.