Skip to content

Commit 6689a98

Browse files
kumarrishavrichardlau
authored andcommittedApr 17, 2024··
http: remove closeIdleConnections function while calling server close
Correcting the #50194 backporting mistake. closeIdleConnections shouldnot be called while server.close in node v18. This behavior is for node v19 and above. Fixes: #52330 Fixes: #51677 PR-URL: #52336 Refs: #50194 Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
1 parent 678641f commit 6689a98

File tree

3 files changed

+2
-1
lines changed

3 files changed

+2
-1
lines changed
 

‎lib/_http_server.js

-1
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,6 @@ function setupConnectionsTracking() {
506506
}
507507

508508
function httpServerPreClose(server) {
509-
server.closeIdleConnections();
510509
clearInterval(server[kConnectionsCheckingInterval]);
511510
}
512511

‎test/parallel/test-http-server-close-idle.js

+1
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ server.listen(0, function() {
4242
assert(response.startsWith('HTTP/1.1 200 OK\r\nConnection: keep-alive'));
4343
assert.strictEqual(connections, 2);
4444

45+
server.closeIdleConnections();
4546
server.close(common.mustCall());
4647

4748
// Check that only the idle connection got closed

‎test/parallel/test-https-server-close-idle.js

+1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ server.listen(0, function() {
5252
assert(response.startsWith('HTTP/1.1 200 OK\r\nConnection: keep-alive'));
5353
assert.strictEqual(connections, 2);
5454

55+
server.closeIdleConnections();
5556
server.close(common.mustCall());
5657

5758
// Check that only the idle connection got closed

0 commit comments

Comments
 (0)
Please sign in to comment.