From 6751b6dc3da102f259b74b7453032edadc7a37ca Mon Sep 17 00:00:00 2001 From: James M Snell Date: Mon, 12 Oct 2020 08:27:58 -0700 Subject: [PATCH] test: check for AbortController existence Running tests comparitively on older versions of Node.js that do not have AbortController can be a pain. Only add the AbortController to knownGlobals if it actually exists. Signed-off-by: James M Snell PR-URL: https://github.com/nodejs/node/pull/35616 Reviewed-By: Denys Otrishko Reviewed-By: Yongsheng Zhang Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel Reviewed-By: Richard Lau Reviewed-By: Rich Trott --- test/common/index.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/test/common/index.js b/test/common/index.js index 58f35f37abf30a..35122e607ed991 100644 --- a/test/common/index.js +++ b/test/common/index.js @@ -253,7 +253,6 @@ function platformTimeout(ms) { } let knownGlobals = [ - AbortController, clearImmediate, clearInterval, clearTimeout, @@ -264,6 +263,15 @@ let knownGlobals = [ queueMicrotask, ]; +// TODO(@jasnell): This check can be temporary. AbortController is +// not currently supported in either Node.js 12 or 10, making it +// difficult to run tests comparitively on those versions. Once +// all supported versions have AbortController as a global, this +// check can be removed and AbortController can be added to the +// knownGlobals list above. +if (global.AbortController) + knownGlobals.push(global.AbortController); + if (global.gc) { knownGlobals.push(global.gc); }