tools: re-implement lint-md without unified-args

`unified-args` ignores settings in the preset, expecting them to be in
remarkrc files or passed on the command line instead. Realizing that
we always send the same configuration options via the command-line
anyway, this removes `unified-args`. This means the preset settings are
now respected and it removes nearly 30000 lines of code in the resulting
rollup file.

I wasn't sure I was going to want to keep rollup so I started
re-implementing this without it, but ended up putting a minimal rollup
back as it still saves about 90000 lines of code vs. checking in
`node_modules`.

PR-URL: #40180
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: Trott

.eslintignore

@@ -4,8 +4,7 @@ test/addons/??_*
 test/fixtures
 test/message/esm_display_syntax_error.mjs
 tools/icu
-tools/lint-md.mjs
-tools/node-lint-md-cli-rollup/dist
+tools/lint-md/lint-md.mjs
 benchmark/tmp
 doc/**/*.js
 !.eslintrc.js

.github/workflows/linters.yml

@@ -55,7 +55,7 @@ jobs:
       - name: Get release version numbers
         if: ${{ github.event.pull_request && github.event.pull_request.base.ref == github.event.pull_request.base.repo.default_branch }}
         id: get-released-versions
-        run: ./tools/node-lint-md-cli-rollup/src/list-released-versions-from-changelogs.mjs
+        run: ./tools/lint-md/list-released-versions-from-changelogs.mjs
       - name: Lint docs
         run: |
           echo "::add-matcher::.github/workflows/remark-lint-problem-matcher.json"

Makefile

@@ -1221,12 +1221,11 @@ bench-addons-clean:
 .PHONY: lint-md-rollup
 lint-md-rollup:
 	$(RM) tools/.*mdlintstamp
-	cd tools/node-lint-md-cli-rollup && npm install
-	cd tools/node-lint-md-cli-rollup && npm run build-node
+	cd tools/lint-md && npm ci && npm run build
 
 .PHONY: lint-md-clean
 lint-md-clean:
-	$(RM) -r tools/node-lint-md-cli-rollup/node_modules
+	$(RM) -r tools/lint-md/node_modules
 	$(RM) tools/.*mdlintstamp
 
 .PHONY: lint-md-build
@@ -1243,7 +1242,7 @@ LINT_MD_TARGETS = doc src lib benchmark test tools/doc tools/icu $(wildcard *.md
 LINT_MD_FILES = $(shell $(FIND) $(LINT_MD_TARGETS) -type f \
 	! -path '*node_modules*' ! -path 'test/fixtures/*' -name '*.md' \
 	$(LINT_MD_NEWER))
-run-lint-md = tools/lint-md.mjs -q -f --no-stdout $(LINT_MD_FILES)
+run-lint-md = tools/lint-md/lint-md.mjs $(LINT_MD_FILES)
 # Lint all changed markdown files maintained by us
 tools/.mdlintstamp: $(LINT_MD_FILES)
 	$(info Running Markdown linter...)

tools/lint-md/.gitignore

@@ -0,0 +1 @@
+node_modules

tools/lint-md.mjs renamed to tools/lint-md/lint-md.mjs

@@ -0,0 +1,25 @@
+import { unified } from 'unified';
+import remarkParse from 'remark-parse';
+import remarkStringify from 'remark-stringify';
+import presetLintNode from 'remark-preset-lint-node';
+import gfm from 'remark-gfm';
+import { read } from 'to-vfile';
+import { reporter } from 'vfile-reporter';
+
+const paths = process.argv.slice(2);
+
+const linter = unified()
+  .use(remarkParse)
+  .use(gfm)
+  .use(presetLintNode)
+  .use(remarkStringify);
+
+paths.forEach(async (path) => {
+  const file = await read(path);
+  const result = await linter.process(file);
+  if (result.messages.length) {
+    process.exitCode = 1;
+    console.error(reporter(result));
+  }
+  // TODO: allow reformatting by writing `String(result)` to the input file
+});

tools/lint-md/lint-md.src.mjs

@@ -3,7 +3,7 @@
 import fs from 'node:fs';
 import { createInterface } from 'node:readline';
 
-const dataFolder = new URL('../../../doc/changelogs/', import.meta.url);
+const dataFolder = new URL('../../doc/changelogs/', import.meta.url);
 
 const result = [];
 async function getVersionsFromFile(file) {

tools/node-lint-md-cli-rollup/src/list-released-versions-from-changelogs.mjs renamed to tools/lint-md/list-released-versions-from-changelogs.mjs

@@ -0,0 +1,22 @@
+{
+  "name": "lint-md",
+  "description": "markdown linting",
+  "version": "1.0.0",
+  "scripts": {
+    "build": "rollup -f es -p '@rollup/plugin-node-resolve={exportConditions: [\"node\"]}'  -p @rollup/plugin-commonjs lint-md.src.mjs --file lint-md.mjs"
+  },
+  "dependencies": {
+    "remark-gfm": "^2.0.0",
+    "remark-parse": "^10.0.0",
+    "remark-preset-lint-node": "^3.0.1",
+    "remark-stringify": "^10.0.0",
+    "to-vfile": "^7.2.2",
+    "unified": "^10.1.0",
+    "vfile-reporter": "^7.0.2"
+  },
+  "devDependencies": {
+    "@rollup/plugin-commonjs": "^20.0.0",
+    "@rollup/plugin-node-resolve": "^13.0.5",
+    "rollup": "^2.57.0"
+  }
+}

tools/node-lint-md-cli-rollup/package-lock.json renamed to tools/lint-md/package-lock.json

@@ -722,7 +722,7 @@ for /D %%D IN (doc\*) do (
     set "lint_md_files="%%F" !lint_md_files!"
   )
 )
-%node_exe% tools\lint-md.mjs -q -f %lint_md_files%
+%node_exe% tools\lint-md\lint-md.mjs %lint_md_files%
 ENDLOCAL
 goto exit