From 6e06b2ff9da7b15e5c3c5ea0826f73cc5975e19b Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Mon, 12 Jul 2021 07:01:03 -0400 Subject: [PATCH] build: update coverage Makefile target comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Update the comments for the `coverage` Makefile target. - Source files under `lib` are no longer instrumented since https://github.com/nodejs/node/commit/d1dee495db1451e74f5364c8687148a53ff0b50d - Fix the name of the related CI job. PR-URL: https://github.com/nodejs/node/pull/39365 Refs: https://github.com/nodejs/node/pull/25157 Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: James M Snell --- Makefile | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 7f53e21e97a390..8ee578f98a0168 100644 --- a/Makefile +++ b/Makefile @@ -209,11 +209,10 @@ coverage-clean: -type f -exec $(RM) {} \; .PHONY: coverage -# Build and test with code coverage reporting. Leave the lib directory -# instrumented for any additional runs the user may want to make. -# For C++ coverage reporting, this needs to be run in conjunction with configure -# --coverage. html coverage reports will be created under coverage/ -# Related CI job: node-test-commit-linux-coverage +# Build and test with code coverage reporting. HTML coverage reports will be +# created under coverage/. For C++ coverage reporting, this needs to be run +# in conjunction with configure --coverage. +# Related CI job: node-test-commit-linux-coverage-daily coverage: coverage-test ## Run the tests and generate a coverage report. .PHONY: coverage-build