Skip to content

Commit 6e9676e

Browse files
legendecasjuanarbol
authored andcommittedJan 24, 2023
node-api: generalize finalizer second pass callback
Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize or RefBase::Finalize are called once, either from the env's shutdown, or from the env's second pass callback. All existing node-api js tests should pass without a touch. The js_native_api cctest is no longer applicable with this change, just removing it. PR-URL: #44141 Refs: #44071 Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent 14c95ec commit 6e9676e

File tree

8 files changed

+317
-413
lines changed

8 files changed

+317
-413
lines changed
 

‎node.gyp

-1
Original file line numberDiff line numberDiff line change
@@ -1241,7 +1241,6 @@
12411241
'test/cctest/test_base_object_ptr.cc',
12421242
'test/cctest/test_node_postmortem_metadata.cc',
12431243
'test/cctest/test_environment.cc',
1244-
'test/cctest/test_js_native_api_v8.cc',
12451244
'test/cctest/test_linked_binding.cc',
12461245
'test/cctest/test_node_api.cc',
12471246
'test/cctest/test_per_process.cc',

0 commit comments

Comments
 (0)
Please sign in to comment.