Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
crypto: check result of BIO_new in X509ToObject
Match other call sites of BIO_new(BIO_s_mem()) and CHECK the result of
the call.

Refs: fb3a9cd

PR-URL: #41979
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
tniessen authored and danielleadams committed Apr 24, 2022
1 parent 36b9028 commit 70ae0ae
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/crypto/crypto_common.cc
Expand Up @@ -1351,6 +1351,7 @@ MaybeLocal<Object> X509ToObject(
Local<Object> info = Object::New(env->isolate());

BIOPointer bio(BIO_new(BIO_s_mem()));
CHECK(bio);

if (names_as_string) {
// TODO(tniessen): this branch should not have to exist. It is only here
Expand Down

0 comments on commit 70ae0ae

Please sign in to comment.