Skip to content

Commit 70dc1ce

Browse files
committedMar 30, 2020
cli: --perf-prof only works on Linux
PR-URL: #31892 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
1 parent 3deee05 commit 70dc1ce

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed
 

‎doc/api/cli.md

+3
Original file line numberDiff line numberDiff line change
@@ -1155,6 +1155,9 @@ V8 options that are allowed are:
11551155
* `--stack-trace-limit`
11561156
<!-- node-options-v8 end -->
11571157

1158+
`--perf-basic-prof-only-functions`, `--perf-basic-prof`,
1159+
`--perf-prof-unwinding-info`, and `--perf-prof` are only available on Linux.
1160+
11581161
### `NODE_PATH=path[:…]`
11591162
<!-- YAML
11601163
added: v0.1.32

‎test/parallel/test-cli-node-options.js

+5-6
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,14 @@ expectNoWorker('--trace-event-file-pattern {pid}-${rotation}.trace_events ' +
4848
'--trace-event-categories node.async_hooks', 'B\n');
4949
expect('--unhandled-rejections=none', 'B\n');
5050

51-
if (!common.isWindows) {
51+
if (common.isLinux) {
5252
expect('--perf-basic-prof', 'B\n');
5353
expect('--perf-basic-prof-only-functions', 'B\n');
54-
}
5554

56-
if (common.isLinux && ['arm', 'x64'].includes(process.arch)) {
57-
// PerfJitLogger is only implemented in Linux.
58-
expect('--perf-prof', 'B\n');
59-
expect('--perf-prof-unwinding-info', 'B\n');
55+
if (['arm', 'x64'].includes(process.arch)) {
56+
expect('--perf-prof', 'B\n');
57+
expect('--perf-prof-unwinding-info', 'B\n');
58+
}
6059
}
6160

6261
if (common.hasCrypto) {

0 commit comments

Comments
 (0)
Please sign in to comment.