Skip to content

Commit

Permalink
build: remove test-tarball action for windows + osx
Browse files Browse the repository at this point in the history
This GitHub action takes quite a bit of time to build and is regularly
flaky. Removing the OSX and Windows target from this action to avoid
having red actions CI runs.

Refs: #34123

PR-URL: #34440
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
MylesBorins committed Jul 27, 2020
1 parent e1199af commit 70f23eb
Showing 1 changed file with 1 addition and 76 deletions.
77 changes: 1 addition & 76 deletions .github/workflows/build-tarball.yml
Expand Up @@ -13,7 +13,7 @@ jobs:
build-tarball:
env:
PYTHON_VERSION: 3.8
runs-on: macos-latest
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ env.PYTHON_VERSION }}
Expand Down Expand Up @@ -68,78 +68,3 @@ jobs:
run: |
cd $TAR_DIR
make run-ci -j2 V=1 TEST_CI_ARGS="-p dots"
test-tarball-windows:
needs: build-tarball
runs-on: windows-latest
steps:
- name: Set up autocrlf
run: |
git config --global core.autocrlf true
- uses: actions/checkout@v2
- name: Set up Python 3.8
uses: actions/setup-python@v2
with:
python-version: 3.8
- name: Environment Information
run: npx envinfo
- name: Download tarball
uses: actions/download-artifact@v1
with:
name: tarballs
- name: Extract tarball
run: |
7z x tarballs/*.tar.gz
7z x *.tar -ttar
- name: Install deps
run: choco install nasm
- name: Build
run: |
$env:DEBUG_HELPER=1
$tarfile = dir *.tar
cd $tarfile.BaseName
$env:msbuild_args="/binaryLogger:node.binlog"
./vcbuild.bat x64 release msi
echo "::set-env name=TAR_DIR::$pwd"
- name: Copy out directory to checkout dir
run: Move-Item -Path "$env:TAR_DIR\out" -Destination "$env:GITHUB_WORKSPACE"
- name: "Test JS Suites"
shell: cmd
run: |
set DEBUG_HELPER=1
./vcbuild.bat release noprojgen nobuild ignore-flaky test-ci-js
- name: "Test C++ Suites"
shell: cmd
run: |
set DEBUG_HELPER=1
./vcbuild.bat release noprojgen nobuild ignore-flaky test-ci-native
test-tarball-macOS:
needs: build-tarball
runs-on: macos-latest
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v1
with:
PYTHON_VERSION: ${{ env.PYTHON_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Download tarball
uses: actions/download-artifact@v1
with:
name: tarballs
- name: Extract tarball
run: |
tar xzf tarballs/*.tar.gz
echo "::set-env name=TAR_DIR::`basename tarballs/*.tar.gz .tar.gz`"
- name: Copy directories needed for testing
run: |
cp -r tools/node_modules $TAR_DIR/tools
cp -r tools/eslint-rules $TAR_DIR/tools
- name: Build
run: |
cd $TAR_DIR
make build-ci -j8 V=1
- name: Test
run: |
cd $TAR_DIR
make run-ci -j8 V=1 TEST_CI_ARGS="-p dots"

0 comments on commit 70f23eb

Please sign in to comment.