From 71b9f792237b39f283eff4cd7ed35212e8669a45 Mon Sep 17 00:00:00 2001 From: Aaron Friel Date: Tue, 13 Dec 2022 11:48:13 -0800 Subject: [PATCH] deps: V8: cherry-pick 30861a39323d MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Original commit message: [debug] Re-enable internal [[Scopes]] property We received feedback that the [[Scopes]] property has some legitimate use-cases not covered by the Scopes View during pause. We re-enable the feature for now and will remove the flag in a follow-up. R=bmeurer@chromium.org Bug: chromium:1365858 Change-Id: Ibf279ae6c4f5ae492d03e9b4ee7316f6500508d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4099385 Auto-Submit: Simon Zünd Commit-Queue: Benedikt Meurer Commit-Queue: Simon Zünd Reviewed-by: Benedikt Meurer Cr-Commit-Position: refs/heads/main@{#84800} Refs: https://github.com/v8/v8/commit/30861a39323d2d4263b2b9f5d9740134d4104cd3 PR-URL: https://github.com/nodejs/node/pull/45851 Reviewed-By: Yagiz Nizipli Reviewed-By: Michaël Zasso Reviewed-By: James M Snell --- common.gypi | 2 +- deps/v8/src/flags/flag-definitions.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index 9fcee7f066e202..5cdbee775864c8 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.7', + 'v8_embedder_string': '-node.8', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/flags/flag-definitions.h b/deps/v8/src/flags/flag-definitions.h index de998e397a5614..dae03199f1c834 100644 --- a/deps/v8/src/flags/flag-definitions.h +++ b/deps/v8/src/flags/flag-definitions.h @@ -1715,7 +1715,7 @@ DEFINE_BOOL(experimental_value_unavailable, false, DEFINE_BOOL(experimental_reuse_locals_blocklists, true, "enable reuse of local blocklists across multiple debug-evaluates") -DEFINE_BOOL(experimental_remove_internal_scopes_property, true, +DEFINE_BOOL(experimental_remove_internal_scopes_property, false, "don't report the artificial [[Scopes]] property for functions") // disassembler